Skip to content

Un-skip previously-broken test_get_type_hints_modules_forwardref#149048

Merged
JelleZijlstra merged 1 commit intopython:mainfrom
KowalskiThomas:kowalski/test-restore-previously-broken-test-for-typing
Apr 27, 2026
Merged

Un-skip previously-broken test_get_type_hints_modules_forwardref#149048
JelleZijlstra merged 1 commit intopython:mainfrom
KowalskiThomas:kowalski/test-restore-previously-broken-test-for-typing

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented Apr 27, 2026

What is this PR?

This PR removes the skip decorator on a test that used to be broken but that was "accidentally fixed" by a previous change.

I don't think this warrants a news entry nor a dedicated issue so leaving it like that unless a reviewer thinks it should be otherwise.

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Apr 27, 2026
@KowalskiThomas KowalskiThomas changed the title Un-skip a test Un-skip previously-broken test_get_type_hints_modules_forwardref Apr 27, 2026
@KowalskiThomas KowalskiThomas marked this pull request as ready for review April 27, 2026 11:59
@JelleZijlstra
Copy link
Copy Markdown
Member

Nice! Is this also fixed on the 3.14 and 3.13 branches?

@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

I believe the fix for the test was introduced in your ac14d4a commit, which apparently did go into 3.14, so I would say it does "need" to get backported to 3.14 for completeness' sake.

@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Apr 27, 2026
@JelleZijlstra JelleZijlstra merged commit a386a52 into python:main Apr 27, 2026
58 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @KowalskiThomas for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

Sorry, @KowalskiThomas and @JelleZijlstra, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a386a52d8c093381792e39f93eb1df63d1584b9e 3.14

@bedevere-bot
Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 Refleaks NoGIL 3.x (tier-2) has failed when building commit a386a52.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1368/builds/5044) and take a look at the build logs.
  4. Check if the failure is related to this commit (a386a52) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1368/builds/5044

Failed tests:

  • test_zipfile

Failed subtests:

  • test_write_without_source_date_epoch - test.test_zipfile.test_core.OtherTests.test_write_without_source_date_epoch

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_zipfile/test_core.py", line 1906, in test_write_without_source_date_epoch
    self.assertAlmostEqual(z_time, c_time, delta=1)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 32 != 34 within 1 delta (2 difference)


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.itamaro-macos-arm64-aws.macos-with-brew.refleak.nogil/build/Lib/test/test_zipfile/test_core.py", line 1906, in test_write_without_source_date_epoch
    self.assertAlmostEqual(z_time, c_time, delta=1)
    ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 48 != 50 within 1 delta (2 difference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs backport to 3.14 bugs and security fixes skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants